Horton

Re: Parallel Bitmap scans a bit broken

Emre Hasegeli <emre@hasegeli.com>

View thread View on postgr.es
From: Emre Hasegeli <emre@hasegeli.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, David Rowley <david.rowley@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-03-15T16:32:58Z
Lists: pgsql-hackers 
> This can crash at line:414, if either tuple is invalid memory(but I
> think it's not because we have already accessed this memory in above
> if check) or dtup is invalid (this is also not possible because
> brin_new_memtuple has already accessed this).

I was testing with the brin correlation patch [1] applied.  I cannot
crash it without the patch either.  I am sorry for not testing it
before.  The patch make BRIN selectivity estimation function access
more information.

[1] https://www.postgresql.org/message-id/attachment/50164/brin-correlation-v3.patch

Commits

  1. Avoid access to uninitialized memory in shared tidbitmap iteration.

  2. Bump catversion for MACADDR8

  3. Fix bug in parallel tidbitmap iteration.