Re: [PATCH] Improve geometric types

Emre Hasegeli <emre@hasegeli.com>

View thread View on postgr.es

From: Emre Hasegeli <emre@hasegeli.com>

To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2017-09-27T15:44:52Z

Lists: pgsql-hackers

Attachments

0001-geo-funcs-v03.patch (application/octet-stream) patch v3-0001
0002-float-header-v07.patch (application/octet-stream) patch v7-0002
0003-geo-float-v04.patch (application/octet-stream) patch v4-0003
0004-line-fixes-v03.patch (application/octet-stream) patch v3-0004

The new versions of the patches are attached addressing your comments.

> C++ surely make just static functions inlined but I'm not sure C
> compiler does that.

Thank you for your explanation.  I marked the mentioned functions "inline".

> So we should be safe to have a buffer with 26 byte length and 500
> bytes will apparently too large and even 128 will be too loose in
> most cases. So how about something like the following?
>
> #define MINDOUBLEWIDTH 32

I left this part out for now.  We can improve it separately.

Commits

Improve test coverage of geometric types
- a3d2844852dc 12.0 landed
Fix problems in handling the line data type
- 2e2a392de391 12.0 landed
Use the built-in float datatypes to implement geometric types
- c4c340088546 12.0 landed
Remove remaining GEODEBUG references from geo_ops.c
- a082aed0723c 12.0 landed
Provide separate header file for built-in float types
- 6bf0bc842bd7 12.0 landed
Refactor geometric functions and operators
- a7dc63d904a6 12.0 landed
Fix crash in close_ps() for NaN input coordinates.
- 278148907a97 9.6.0 cited
Fix GiST index build for NaN values in geometric types.
- 1acf75725545 9.6.0 cited
Enable building with Visual Studion 2013.
- cec8394b5ccd 9.4.0 cited
Suppress -0 in the C field of lines computed by line_construct_pts().
- 43fe90f66a0b 9.4.0 cited