_isnan() on Windows

Emre Hasegeli <emre@hasegeli.com>

View thread View on postgr.es

From: Emre Hasegeli <emre@hasegeli.com>

To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Andres Freund <andres@anarazel.de>

Date: 2018-07-10T17:36:39Z

Lists: pgsql-hackers

Attachments

win32_port_float_h_v00.patch (application/octet-stream) patch v0

isnan() function is evidently not present on <math.h> on Windows
before Visual Studio 2013.  We define it on win32_port.h using
_isnan().  However _isnan() is also not present.  It is on <float.h>.
The patch is attached to include this from win32_port.h.

Thanks to Thomas Munro for point this out to me [1].  It is hard to
notice this issue without testing the changes on Windows.

[1] https://www.postgresql.org/message-id/CAEepm%3D3dE0w%3D_dOcELpPum6suze2NZwc%3DAV4T_xYrDUoHbZJvA%40mail.gmail.com

Commits

Silence MSVC warnings about redefinition of isnan
- d5d7f7f3b78e 12.0 landed
Rethink how to get float.h in old Windows API for isnan/isinf
- f2c587067a8e 12.0 landed