Horton

Re: New Defects reported by Coverity Scan for PostgreSQL

Emre Hasegeli <emre@hasegeli.com>

View thread View on postgr.es
From: Emre Hasegeli <emre@hasegeli.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Ning Yu <nyu@pivotal.io>, pgsql-hackers@postgresql.org
Date: 2018-11-06T17:40:21Z
Lists: pgsql-hackers

Attachments

> Surely the comment in line 3839 deserves an update :-)

Done.

> This seems good material.  I would put the detailed conventions comment
> separately from the head of the file, like this (where I also changed
> "Type1 *type1" into "Type1 *obj1", and a few "has" to "have")

Looks better to me.  I found one more "has" and changed it.

Commits

  1. geo_ops.c: Clarify comments and function arguments

  2. Refactor geometric functions and operators