Horton

Re: BRIN range operator class

Emre Hasegeli <emre@hasegeli.com>

View thread View on postgr.es
From: Emre Hasegeli <emre@hasegeli.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2015-05-05T09:57:40Z
Lists: pgsql-hackers

Attachments

> From my point of view as a reviewer this patch set is very close to being
> committable.

Thank you.  The new versions are attached.

> - "operator classes store the union of the values in the indexed column" is
> not technically true. It stores something which covers all of the values.

I rephrased it as " operator classes store a value which includes the
values in the indexed column".

> - Missing space in "except box and point*/".

Fixed.

> = brin-inclusion-v06-07-remove-minmax-amprocs.patch
>
> Shouldn't this be merged with 02? Otherwise it looks good.

It doesn't have any relation with the 02-strategy-numbers.patch.
Maybe you mean 01-sql-level-support-functions.patch and
05-box-vs-point-operators.patch should be merged.  They can always be
committed together.

Commits

  1. Refactor per-page logic common to all redo routines to a new function.

  2. Reduce use of heavyweight locking inside hash AM.

  3. Scan the buffer pool just once, not once per fork, during relation drop.

  4. Major patch from Thomas Lockhart <Thomas.G.Lockhart@jpl.nasa.gov>