Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

From: Vladimir Rusinov <vrusinov@google.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Jim Nasby <Jim.Nasby@bluetreble.com>, David Steele <david@pgmasters.net>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-12T16:00:12Z
Lists: pgsql-hackers

Attachments

On Thu, Jan 12, 2017 at 5:49 AM, Michael Paquier <michael.paquier@gmail.com>
wrote:

> The patch still updates a bunch of .po files. Those are normally
> refreshed with the translation updates, so they had better be removed.
> Other than that, the patch looks in good shape to me so switch to
> "Ready for committer".
>

Gotcha. Excluded these from the new version of the patch. It's actually
same as above but produced with some git :(exclude) magic.


> So, to sum up things on this thread, here are the votes about the use
> of aliases or a pure breakage:
> - No to aliases, shake the world: Stephen, Tom, David F, Vik, Bruce M => 5
> - Yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N,
> Vladimir, Simon R, Fujii-san => 8
> If I misunderstood things, please feel free to speak up.
>

Counting amendments and more votes down the thread:

- no aliases: Stephen, Tom, David F, Vik, Bruce M, David Steele, Robert
Haas => 7
- yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, Vladimir,
Simon R => 7
- avoid renaming altogether: Fujii-san => 1

Duh. Folks, you are not making it easy. :) Looks like we need one more vote.

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid