Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

From: Vladimir Rusinov <vrusinov@google.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>, Jim Nasby <Jim.Nasby@bluetreble.com>, David Steele <david@pgmasters.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-05T16:31:56Z
Lists: pgsql-hackers

Attachments

Attaching a patch that renames all 'xlog' functions, keeping aliases for
old ones (since it looks like majority vote is for keeping them).

Following functions have been renamed:

    Name                            |   Replaced by
    --------------------------------|-------------------------------
    pg_current_xlog_flush_location  | pg_current_wal_flush_location
    pg_current_xlog_insert_location | pg_current_wal_insert_location
    pg_current_xlog_location        | pg_current_wal_location
    pg_is_xlog_replay_paused        | pg_is_recovery_paused
    pg_last_xlog_receive_location   | pg_last_wal_receive_location
    pg_last_xlog_replay_location    | pg_last_wal_replay_location
    pg_switch_xlog                  | pg_switch_wal
    pg_xlog_location_diff           | pg_wal_location_diff
    pg_xlog_replay_pause            | pg_pause_recovery
    pg_xlog_replay_resume           | pg_resume_recovery
    pg_xlogfile_name                | pg_wal_file_name
    pg_xlogfile_name_offset         | pg_wal_file_name_offset


Questions/possible follow-up work:

- OIDs - where do I get numbers from? I was kinda choosing them at random,
unaware if there is some process for keeping track of them. Please point me
if such thing exists and I'll change them.
- Documentation. I've added a new section with a simple table, keeping it
somewhat neglected on purpose. We'll have old names in index and searchable
on page, but nothing more. Is it sufficient?
- New function names. I've used 'recovery' instead of 'xlog_replay' and
used 'wal_file' instead of 'xlogfile'. Does it make sense?
- Release notes. I was unable to find a draft for 10.0. How do I make sure
these renames are not forgotten?

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid