Horton

Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

View thread View on postgr.es
From: Vladimir Rusinov <vrusinov@google.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Michael Paquier <michael.paquier@gmail.com>
Date: 2016-12-14T16:20:00Z
Lists: pgsql-hackers 
On Wed, Dec 14, 2016 at 4:07 PM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> On 12/13/16 12:47 PM, Vladimir Rusinov wrote:
> > Based on discussion in
> > https://www.postgresql.org/message-id/CAE1wr-w%
> 3DLE1cK5uG_rmAh-VBxc4_Bnw-gAE3qSqL-%3DtWwvLvjQ%40mail.gmail.com.
> >
> > Tested via regression tests.
> > To be applied in master only and to be included in 10.0.
>
> I don't think the idea was to rename just one "xlog" function to "wal".
>

Others will follow later in separate patches. Or is it preferred to have
one huge patch submitted?

Personally, I think this is not important, but if you want to do it, I'd
> follow the suggestion in the thread to rename all functions and leave
> the old names as aliases or wrappers of some kind.
>

I think I agree with Michael Paquier: "Better to do breakages in a single
release rather than spreading them across releases.".
There's going to be a lot of broken scripts following pg_xlog rename, so I
think it makes sense to just drop functions as well. We don't maintain
pg_xlog -> pg_wal symlink, do we?

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid