Horton

Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

View thread View on postgr.es
From: Vladimir Rusinov <vrusinov@google.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Jim Nasby <Jim.Nasby@bluetreble.com>, David Steele <david@pgmasters.net>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-09T16:53:44Z
Lists: pgsql-hackers

Attachments

On Mon, Jan 9, 2017 at 4:14 PM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> > pg_is_xlog_replay_paused        | pg_is_recovery_paused
>
> All the other xlog_replay names have been changed to wal_replay, so
> making this one different is probably not so good.
>

Oops, forgot about that one. Attached patch with this addressed as well.

    Remove 'xlog' references from admin functions.

    After 'pg_xlog' has been renamed to 'pg_wal' 'xlog' reference in
function names is confusing.
    This change renames 'xlog' in function names to 'wal', keeping old
    function names as aliases.

    Following functions have been renamed:

    Name                            |   Replaced by
    --------------------------------|-------------------------------
    pg_current_xlog_flush_location  | pg_current_wal_flush_location
    pg_current_xlog_insert_location | pg_current_wal_insert_location
    pg_current_xlog_location        | pg_current_wal_location
    pg_is_xlog_replay_paused        | pg_is_wal_replay_paused
    pg_last_xlog_receive_location   | pg_last_wal_receive_location
    pg_last_xlog_replay_location    | pg_last_wal_replay_location
    pg_switch_xlog                  | pg_switch_wal
    pg_xlog_location_diff           | pg_wal_location_diff
    pg_xlog_replay_pause            | pg_wal_replay_pause
    pg_xlog_replay_resume           | pg_wal_replay_resume
    pg_xlogfile_name                | pg_wal_file_name
    pg_xlogfile_name_offset         | pg_wal_file_name_offset

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid