Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

From: Vladimir Rusinov <vrusinov@google.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@timbira.com.br>, David Steele <david@pgmasters.net>, Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>, Jim Nasby <Jim.Nasby@bluetreble.com>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-24T10:53:30Z
Lists: pgsql-hackers
On Mon, Jan 23, 2017 at 6:59 PM, Stephen Frost <sfrost@snowman.net> wrote:

> > For the record, I don't like the name "xlog" either.  It would be nice
> > if we could have more consistent and intuitive naming.
> >
> > But I don't see any proposals to actually change all uses of "xlog" to
> > "wal".  What about program names, command line options, etc.?  If the
> > argument is, we changed one thing, we should change the rest, then let's
> > see that.  I think that argument itself is flawed, but if that's what
> > we're going with, let's see the whole plan.
>
> That is the proposal and what Vladimir is working towards, as I
> understand it, but one piece at a time rather than one big huge patch,
> as he's already stated elsewhere on this thread.
>

Correct. Since fate of this patch is not fully decided I've paused my work
on other things until this goes in in some form.


> I don't have any problem with asking for a summary of the exact set of
> changes that he's planning to make though.  My understanding is that it
> includes changing program names, command line options, etc.
>

Here's what I currently have in mind:

- sql function names (current patch)
- binaries in bin: pg_receivexlog, pg_xlogdump, pg_resetxlog
- (maybe) public/exported symbols from libpq,
e.g. libpqGetCurrentXlogInsertLocation
- at this time I don't target internal function and filenames, but that
could also be done if there's desire for this.

I'd like to have most user-visible changed checked in earlier. Stuff like
internal refactoring can be done pretty much at any point in development
cycle.

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid