Horton

Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Vladimir Rusinov <vrusinov@google.com>

View thread View on postgr.es
From: Vladimir Rusinov <vrusinov@google.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@timbira.com.br>, David Steele <david@pgmasters.net>, Michael Paquier <michael.paquier@gmail.com>, Stephen Frost <sfrost@snowman.net>, Jim Nasby <Jim.Nasby@bluetreble.com>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-30T11:01:29Z
Lists: pgsql-hackers 
On Fri, Jan 27, 2017 at 11:03 PM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> 1. Rename nothing
> 2. Rename directory only
> 3. Rename everything
>

3 or 1 (with a slight preference for 3).

Not sure if my vote counts, but for me as ex-DBA consistency mattered *a
lot*.
This is one of the reasons PostgreSQL is actually nicer to work with than
many other databases. I remember 'wal' vs 'xlog' was actually one of a very
few confusing things. I think it is important to stick to just one term,
whether it be wal or xlog. I'd prefer wal since it's a term used in many
other systems. 'xlog' may be confused with likes of binary log in MySQL
which is not what it is.

Now, I've rebased my patches to rename functions (with and without aliases)
on top of current master, but there's probably no point of posting them now
given there are patches above that rename other things as well.

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid