Horton

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

Pantelis Theodosiou <ypercube@gmail.com>

View thread View on postgr.es
From: Pantelis Theodosiou <ypercube@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Dilger <hornschnorter@gmail.com>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers <pgsql-hackers@postgresql.org>, Hao Lee <mixtrue@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, Andrew Dunstan <andrew@dunslane.net>
Date: 2018-05-15T18:50:40Z
Lists: pgsql-hackers 
On Tue, May 15, 2018 at 6:29 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Mark Dilger <hornschnorter@gmail.com> writes:
>
> > I don't have a strong opinion on that.  I could also look to upgrade
> > to a newer version.  Generally, I try to build using the oldest
> > supported version rather than the newest.  What is the next oldest
> > working test machine you have?
>
> thrips is described as running VS2010, though I'm not sure how to verify
> that it's not been updated.  The make log shows
>
>   c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\AMD64\CL.exe
>
> but is "10.0" the same thing as "2010"?
>
>                         regards, tom lane
>
>
According to Wikipedia, yes:
https://en.wikipedia.org/wiki/Microsoft_Visual_Studio

(although the 10s are only by coincidence, 11.0 is VS 2012, ...)

Commits

  1. Fix for globals.c- c.h must come first

  2. Allow group access on PGDATA

  3. Refactor dir/file permissions