Re: PITR promote bug: Checkpointer writes to older timeline
Soumyadeep Chakraborty <soumyadeep2007@gmail.com>
From: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Fujii Masao <masao.fujii@oss.nttdata.com>, Heikki Linnakangas <hlinnaka@iki.fi>,
pgsql-hackers <pgsql-hackers@postgresql.org>, jyih@vmware.com, kyeap@vmware.com
Date: 2021-03-04T23:42:05Z
Lists: pgsql-hackers
Attachments
- tap_test_prepared_xact_pitr.patch (text/x-patch) patch
Hey all, I took a stab at a quick and dirty TAP test (my first ever). So it can probably be improved a lot. Please take a look. On Thu, Mar 04, 2021 at 10:28:31AM +0900, Kyotaro Horiguchi wrote: > 2. Restore ThisTimeLineID after calling XLogReadRecord() in the > *caller* side. This is what came up to me first but I don't like > this, too, but I don't find better fix. way. +1 to this patch [1]. The above TAP test passes with this patch applied. [1] https://www.postgresql.org/message-id/attachment/119972/dont_change_thistimelineid.patch Regards, Soumyadeep Regards, Soumyadeep
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix timeline assignment in checkpoints with 2PC transactions
- 1ec7162a8d34 10.17 landed
- f1d550f188e2 11.12 landed
- 4b1dd9b1ea75 12.7 landed
- 6e5ce888ad1e 13.3 landed
- 595b9cba2ab0 14.0 landed