Horton

Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch

Soumyadeep Chakraborty <soumyadeep2007@gmail.com>

View thread View on postgr.es
From: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-09-28T06:01:05Z
Lists: pgsql-hackers

Attachments

Hey,

I completely agree, that was an important consideration.

I had some purely cosmetic suggestions:
1. Rename ExecComputeSlotInfo to eliminate the need for the asserts.
2. Extract return value to a bool variable for slightly better
readability.
3. Taking the opportunity to use TTS_IS_VIRTUAL.

v2 of patch set attached. The first two patches are unchanged, the cosmetic
changes are part of v2-0003-Some-minor-cosmetic-changes.patch.

--
Soumyadeep

Commits

  1. Don't generate EEOP_*_FETCHSOME operations for slots know to be virtual.

  2. Reduce code duplication for ExecJust*Var operations.