Re: [v9.2] DROP statement reworks
Kohei KaiGai <kaigai@kaigai.gr.jp>
From: Kohei KaiGai <kaigai@kaigai.gr.jp>
To: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: Robert Haas <robertmhaas@gmail.com>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-09-28T15:51:40Z
Lists: pgsql-hackers
Attachments
- pgsql-v9.2-drop-reworks-1.v3.patch (application/octet-stream) patch v9
- pgsql-v9.2-drop-reworks-2.v3.patch (application/octet-stream) patch v9
- pgsql-v9.2-drop-reworks-3.v3.patch (application/octet-stream) patch v9
2011/9/25 Dimitri Fontaine <dimitri@2ndquadrant.fr>: > Hi, > > Kohei KaiGai <kaigai@kaigai.gr.jp> writes: >> 2011/8/15 Kohei KaiGai <kaigai@kaigai.gr.jp>: >>> The attached three patches try to consolidate code path of DROP >>> statement on various kind of object classes. >> >> These are rebased to the latest tree, and the part-3 portion also consolidates >> DROP OPERATOR FAMILY/CLASS routines that I forgot to rework in the >> previous patch. > > I've been reviewing those patches, that are all about code refactoring. > I like what it's doing, generalizing ad-hoc code by adding some more > knowledge about the source tree into some data structures. Typically, > what catcache to use for a given object's class-id. > > The patches are not in git am format nor in patch format, so I could > only read them, I didn't install them nor compiled the code, didn't run > the regression tests. > Thanks for your efforts. I rebased the patches towards the latest git master, so I believe these are available to apply. Thanks, -- KaiGai Kohei <kaigai@kaigai.gr.jp>