Re: [v9.2] Fix Leaky View Problem

Kohei KaiGai <kaigai@kaigai.gr.jp>

From: Kohei KaiGai <kaigai@kaigai.gr.jp>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, Kevin Grittner <Kevin.Grittner@wicourts.gov>, Kohei.Kaigai@emea.nec.com, thom@linux.com, pgsql-hackers@postgresql.org

Date: 2012-01-08T15:32:41Z

Lists: pgsql-hackers

Attachments

pgsql-regtest-leaky-views.2.patch (application/octet-stream) patch

>> I guess you concerned about that expected/select_views_1.out is
>> patched, not expected/select_views.out.
>> I'm not sure the reason why regression test script tries to make diff
>> between results/select_views and expected/select_views_1.out.
>
> select_views.out and select_views_1.out are alternate expected output
> files.  The regression tests pass if the actual output matches either
> one.  Thus, you have to patch both.
>
It was new for me. The attached patch updates both of the expected
files, however, I'm not certain whether select_view.out is suitable, or
not, because my results/select_view.out matched with expected/select_view_1.out.

> BTW, can you also resubmit the leakproof stuff as a separate patch for
> the last CF?  Want to make sure we get that into 9.2, if at all
> possible.
>
Yes, it shall be attached on the next message.

Thanks,
-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>