Re: ALTER command reworks
Kohei KaiGai <kaigai@kaigai.gr.jp>
From: Kohei KaiGai <kaigai@kaigai.gr.jp>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2013-01-15T15:40:29Z
Lists: pgsql-hackers
2013/1/15 Alvaro Herrera <alvherre@2ndquadrant.com>: > Kohei KaiGai escribió: > >> The attached patch is a rebased version towards the latest master >> branch, and fix up the issue around error messages on name conflicts. > > I assume the lock.c changes are just a bollixed merge, right? > Yes, I'll check it and rebase it. > I am not sure about some of the changes in the regression test expected > output; are we really okay with losing the "in schema foo" part in some > of these cases? > The changes in the expected results in regression test originated from elimination of getObjectDescription, but "in schema foo" should be kept. It looks like an obvious my mistake. Sorry. Thanks, -- KaiGai Kohei <kaigai@kaigai.gr.jp>