Horton
Menu

Re: Custom Scan APIs (Re: Custom Plan node)

Kohei KaiGai <kaigai@kaigai.gr.jp>

View thread
From: Kohei KaiGai <kaigai@kaigai.gr.jp>
To: Jim Mlodgenski <jimmy76@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PgHacker <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter_e@gmx.net>, Shigeru Hanada <shigeru.hanada@gmail.com>
Date: 2013-11-19T14:41:58Z
Lists: pgsql-hackers

Attachments

Thanks for your review.

2013/11/19 Jim Mlodgenski <jimmy76@gmail.com>:
> My initial review on this feature:
> - The patches apply and build, but it produces a warning:
> ctidscan.c: In function ‘CTidInitCustomScanPlan’:
> ctidscan.c:362:9: warning: unused variable ‘scan_relid’ [-Wunused-variable]
>
This variable was only used in Assert() macro, so it causes a warning if you
don't put --enable-cassert on the configure script.
Anyway, I adjusted the code to check relid of RelOptInfo directly.

> I'd recommend that you split the part1 patch containing the ctidscan contrib
> into its own patch. It is more than half of the patch and its certainly
> stands on its own. IMO, I think ctidscan fits a very specific use case and
> would be better off being an extension instead of in contrib.
>
OK, I split them off. The part-1 is custom-scan API itself, the part-2 is
ctidscan portion, and the part-3 is remote join on postgres_fdw.

Thanks,
-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Support multi-argument UNNEST(), and TABLE() syntax for multiple functions.