Horton
Menu

Re: pg_basebackup: Always return valid temporary slot names

Nishant Sharma <nishant.sharma@enterprisedb.com>

View thread
From: Nishant Sharma <nishant.sharma@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jelte Fennema <me@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jim Jones <jim.jones@uni-muenster.de>
Date: 2023-09-06T05:55:35Z
Lists: pgsql-hackers 
On Tue, Sep 5, 2023 at 4:40 PM Jelte Fennema <me@jeltef.nl> wrote:

> I modified the PgBouncer PR to always set the sign bit to 0. But I
> still I think it makes sense to also address this in pg_basebackup.


Sounds good to me. Thank you!


On Tue, Sep 5, 2023 at 5:36 PM Daniel Gustafsson <daniel@yesql.se> wrote:

> Since the value in the temporary slotname isn't used to convey meaning, but
> merely to ensure uniqueness, I don't think it's unreasonable to guard
> aginst
> malformed input (ie negative integer).
>

 Ok. In this case, I also agree.


+1 to the patch from my side. Thank you!


Regards,
Nishant.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_basebackup: Generate valid temporary slot names under PQbackendPID()