[Code Cleanup] : Small code cleanup in twophase.sql
Nishant Sharma <nishant.sharma@enterprisedb.com>
From: Nishant Sharma <nishant.sharma@enterprisedb.com>
To: pgsql-hackers@postgresql.org
Date: 2023-09-26T13:01:42Z
Lists: pgsql-hackers
Attachments
- v1-0001-Small-code-cleanup-in-twophase.sql.patch (application/octet-stream) patch v1-0001
Hi, PFA small code cleanup in twophase.sql. Which contains a drop table statement for 'test_prepared_savepoint'. Which, to me, appears to be missing in the cleanup section of that file. To support it I have below points:- 1) Grepping this table 'test_prepared_savepoint' shows occurrences only in twophase.out & twophase.sql files. This means that table is local to that sql test file and not used in any other test file. 2) I don't see any comment on why this was not added in the cleanup section of twophase.sql, but drop for other two test tables are done. 3) I ran "make check-world" with the patch and I don't see any failures. Kindly correct, if I missed anything. Regards, Nishant (EDB).
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
test_decoding: Remove unnecessary table in twophase test
- 98e89740e5a8 17.0 landed