Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Nishant Sharma <nishant.sharma@enterprisedb.com>

From: Nishant Sharma <nishant.sharma@enterprisedb.com>

To: Jim Jones <jim.jones@uni-muenster.de>

Cc: Manni Wood <manni.wood@enterprisedb.com>, Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers@postgresql.org

Date: 2025-11-10T09:27:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add infrastructure for pg_get_*_ddl functions
- 4881981f9202 19 (unreleased) landed
Add pg_get_tablespace_ddl() function
- b99fd9fd7f36 19 (unreleased) landed
Split out innards of pg_tablespace_location()
- 877a024902a7 19 (unreleased) landed
Remove spclocation field from pg_tablespace
- 16d8e594acd9 9.2.0 cited

Attachments

v10-0002-Adds-pg_get_tablespace_ddl-function.patch (application/octet-stream) patch v10-0002
v10-0001-Supporting-changes-for-pg_get_tablespace_ddl-fun.patch (application/octet-stream) patch v10-0001

1. I have moved our build_tablespace_ddl_string in pg_tablespace.c
2. Removed unnecessary includes in new file pg_tablespace.c
3. Added 'or oid' as type in doc file for documentation along with name.
4. Added 'pg_tablespace.c' in the meson build file.


The problem appears to be with meson build (also suggested by Jim):
https://cirrus-ci.com/task/5376297293053952

Hopefully this resolves the CI issue.

PFA, v10 patch set.


Regards,
Nishant Sharma.
EDB, Pune.
https://www.enterprisedb.com/