Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove pg_spin_delay().

  2. Add a basic atomic ops API abstracting away platform/architecture details.

  1. remove pg_spin_delay() from atomics code

    Nathan Bossart <nathandbossart@gmail.com> — 2026-05-05T17:52:37Z

    While inspecting what 32-bit optimizations we had, I noticed this line in
atomics/arch-x86.h:

    #elif defined(_MSC_VER) && defined(__x86_64__)

...which led me to rediscover what Thomas Munro had found a while back [0],
i.e., we aren't using the right x86_64 macro for MSVC in lots of places.
Upon further inspection, all of this pg_spin_delay() stuff seems to have
been unused since it was added in commit b64d92f1a5, so I'm guessing it's
just an implementation artifact that didn't get cleaned up.

Here's a patch to remove that dead code.

[0] https://postgr.es/m/CA%2BhUKGL8Hs-phHPugrWM%3D5dAkcT897rXyazYzLw-Szxnzgx-rA%40mail.gmail.com

-- 
nathan

  2. Re: remove pg_spin_delay() from atomics code

    Corey Huinker <corey.huinker@gmail.com> — 2026-05-27T06:37:56Z

    >
>
> Here's a patch to remove that dead code.


+1

The patch removes all 0 usages of pg_spin_delay, and all mentions of
pg_spin_delay.

All the associated comments were removed, no more, no less.

Deleted code is debugged code.

  3. Re: remove pg_spin_delay() from atomics code

    Nathan Bossart <nathandbossart@gmail.com> — 2026-05-27T17:43:58Z

    On Wed, May 27, 2026 at 02:37:56AM -0400, Corey Huinker wrote:
> +1
> 
> The patch removes all 0 usages of pg_spin_delay, and all mentions of
> pg_spin_delay.
> 
> All the associated comments were removed, no more, no less.
> 
> Deleted code is debugged code.

Thanks for looking.  FWIW I'm planning to wait until v20 opens for
development before committing this.  That's probably unnecessary, but I see
no advantage to rushing.

-- 
nathan