Re: pg_dump --with-* options

>
>
> > I assume that should be read as something like "include only", because
> > --include=data would also be excluding the schema and the stats.
>
> Of course.
>

In general, I like the idea of --include, but it would need to be
consistent in behavior across pg_dump/pg_restore/pg_upgrade(if applicable).

Under the current defaults, if a person wanted a dump to include stats on
pg_dump they would need "--include=data,schema,statistics" (checking first
whether it was "statistics" or "stats"), but they could use the defaults on
pg_restore. Using the defaults on both would allow for stats to be
restored, but none would have been generated. That is confusing to me, and
I imagine it will be even more confusing to somebody who hasn't been
reading this thread.

I don't see anything wrong with a full complement of --something-only,
--no-something flags. The combinatorics aren't that hard, only tedious. If
we *must* make the defaults for pg_dump different from pg_restore and
pg_upgrade, then adding the --with-something flags becomes necessary, and
we let redundant non-conflicting combinations slide.

All of these problems are solved if we include statistics by default across
all three programs. Anything else involves complicated explanations that
will confuse the users who read them, and surprise the users who don't.