Horton

Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions

Corey Huinker <corey.huinker@gmail.com>

View thread
From: Corey Huinker <corey.huinker@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, Vik Fearing <vik@postgresfriends.org>, Isaac Morland <isaac.morland@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-11-21T22:18:59Z
Lists: pgsql-hackers 
>
> > The same logic applies to RangeVarGetRelidExtendedSafe() and
> > makeRangeVarFromNameListSafe. These can be called from
> > RangeVarGetRelidExtended() and makeRangeVarFromNameList(),
> > respectively.
> > --
> >
>
> I don’t see any way to pass the escontext (ErrorSaveContext) without
> changing
> the textToQualifiedNameList function signature.
> ...
> Am I missing something?
>

I think we need to keep these separate. The execution paths that don't care
about capturing errors shouldn't be slowed down by minority of paths that
do. That may change in the future, but if it does, we'll be getting rid of
a lot of internal functions with this type of difference.