Re: Remove some useless casts to (void *)

Corey Huinker <corey.huinker@gmail.com>

From: Corey Huinker <corey.huinker@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-02T23:59:44Z
Lists: pgsql-hackers
On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut <
peter.eisentraut@enterprisedb.com> wrote:

> I have found that in some corners of the code some calls to standard C
> functions are decorated with casts to (void *) for no reason, and this
> code pattern then gets copied around.  I have gone through and cleaned
> this up a bit, in the attached patches.
>
> The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
> qsort, bsearch
>
> Also hash_search(), for which there was a historical reason (the
> argument used to be char *), but not anymore.


+1

All code is example code.

Applies.
Passes make check world.

Commits

  1. Remove useless casts to (void *) in arguments of some system functions

  2. Remove useless casts to (void *) in hash_search() calls