Re: Import Statistics in postgres_fdw before resorting to sampling.

>
> > AFAICS, postgres_fdw's subsequent uses of those strings only need
> > them to be nul-terminated C strings, so strncpy's property of
> > zero-filling the whole buffer is not needed here.  I recommend
> > s/strncpy/strlcpy/.
>
> Seems like a good idea.
>
> > It's probably also appropriate to think about using pg_mbcliplen()
> > to ensure that this code doesn't result in a broken multibyte
> > character.
>
> Will do.
>
> I am currently overseas and will be attending an event this week, so I
> will work on this after returning home.  In the meantime, I created an
> entry for it in the open items list.
>
> Thanks!


I've attached 2 different fixes.

The first one swtiches to pg_mbcliplen+memcpy, which is probably overkill
but better safe than sorry.

The second gets rid of the string buffers entirely, and instead frees the
nested object.

I have no preference between the two, though I suspect that the nested-free
solution will be preferred by the community.