Re: Extended Statistics set/restore/clear functions.
Corey Huinker <corey.huinker@gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Date: 2025-11-26T05:50:14Z
Lists: pgsql-hackers
On Tue, Nov 25, 2025 at 11:44 PM Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Nov 25, 2025 at 11:37:09PM -0600, Corey Huinker wrote: > > I've reviewed what you committed and it looks good to me aside from the > one > > nitpick I already made. > > I was not really excited about these as it concerns only code local to > each file where the input functions are located, no routines that are > actually published for consumption by other parts of the backend. > -- > Michael > So if a function were previously static to one page, but now had utility outside of that file, you would then consider changing the function signature to add the consts? I ask because this may become relevant with the statatt_* functions being moved in the remaining patches.