Re: vacuumdb: add --dry-run
Corey Huinker <corey.huinker@gmail.com>
From: Corey Huinker <corey.huinker@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-11-19T22:23:48Z
Lists: pgsql-hackers
Attachments
- v2-0001-Add-dry-run-to-vacuumdb.patch (text/x-patch)
> > > My attempts to test this all got stuck in wait_on_slots(). I haven't > > looked too closely, but I suspect the issue is that the socket never > > becomes readable because we don't send a query. If I set > free_slot->inUse > > to false before printing the command, it no longer hangs. We probably > want > > to create a function in parallel_slot.c to mark slots that we don't > intend > > to give a query as idle. > > > > Would that be preferable to skipping the creation of extra connections > for parallel workers? I can see it both ways. On the one hand we want to > give as true a reflection of "what would happen with these options", and on > the other hand one could view the creation of extra workers as "real" vs a > dry run. > > > > > > Now with zero hangs and some test cases. I didn't create a function (yet) as it seemed trivial.