Re: Extended Statistics set/restore/clear functions.

Corey Huinker <corey.huinker@gmail.com>

From: Corey Huinker <corey.huinker@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>, pgsql-hackers@lists.postgresql.org

Date: 2025-12-11T21:52:26Z

Lists: pgsql-hackers

Attachments

v21-0001-Expose-attribute-statistics-functions-for-use-in.patch (text/x-patch)
v21-0002-Add-extended-statistics-support-functions.patch (text/x-patch)
v21-0003-Include-Extended-Statistics-in-pg_dump.patch (text/x-patch)

On Sun, Dec 7, 2025 at 8:26 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Fri, Dec 05, 2025 at 12:30:38AM -0500, Corey Huinker wrote:
> > Attached is a follow-on to Michael's most recent uncommitted patch,
> > changing the errors that I see as "impossible" to elogs. However, I agree
> > that they don't add significant workload to the translations, and most
> > input functions need to avoid any hard error returns lest they be called
> in
> > a soft-error context.
>
> Reporting the state of the parser in these new elogs is OK for me, but
> we had more cases that what your patch has been updating.  I have
> included all these cases, making the set of error messages a bit more
> consistent across the board, and applied the result.
> --
> Michael
>

Rebased. Used new palloc0_array() in a few places, and fixed an expected
output message that wasn't updated to reflect the changes.