Re: Add expressions to pg_restore_extended_stats()

Corey Huinker <corey.huinker@gmail.com>

From: Corey Huinker <corey.huinker@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Chao Li <li.evan.chao@gmail.com>, Tender Wang <tndrwang@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas@vondra.me>

Date: 2026-02-04T10:32:46Z

Lists: pgsql-hackers

Attachments

v5-0001-Add-support-for-exprs-in-pg_restore_extended_stat.patch (text/x-patch) patch v5-0001
v5-0002-FAILED-WIP-errcontext.patch (text/x-patch) patch v5-0002

>
> Okay.  It really sounds to me like an ErrorContextCallback would help
> you here.  I don't see a need to complicate statatt_build_stavalues(),
> but my intuition can also be wrong.
>

Sigh. errsave_finish() only calls errfinish() on elevel >= ERROR, and
that's where the context stack is walked. The failed work in progress is
attached too, mostly as a cautionary tale.

v5-0001 includes tests for null expressions on the leading and trailing end.

Commits

Refactor tests for catalog diff comparisons in stats_import.sql
- ccd7abaa456f 19 (unreleased) landed
Fix typo in stats_import.sql
- 9e8193a26229 19 (unreleased) landed
Add support for "exprs" in pg_restore_extended_stats()
- ba97bf9cb7b4 19 (unreleased) landed
Add information about range type stats to pg_stats_ext_exprs
- 307447e6dbc0 19 (unreleased) landed
Fix comment in extended_stats_funcs.c
- 9476ef206c64 19 (unreleased) landed