Re: Fix --missing-stats-only false positive for partitioned expression indexes

Corey Huinker <corey.huinker@gmail.com>

From: Corey Huinker <corey.huinker@gmail.com>
To: Baji Shaik <baji.pgdev@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-16T16:40:11Z
Lists: pgsql-hackers
On Tue, Jun 16, 2026 at 12:26 PM Baji Shaik <baji.pgdev@gmail.com> wrote:

> On Tue, Jun 16, 2026 at 11:14 AM Nathan Bossart <nathandbossart@gmail.com>
> wrote:
>
>> I'm curious why you added this check to the beginning and surrounded the
>> rest with parentheses.  Wouldn't it be better to follow the example of the
>> surrounding clauses and an "AND NOT p.inherited" somewhere in the middle?
>
>
> Good point. v2 moves the check inside the EXISTS as
> "AND NOT p.inherited", consistent with how the inheritance
> sections below handle it.
>
> v2 attached.
>
> Thanks,
> Baji Shaik.
>

+1

The refactor I was testing differed only in having the new qual one line
higher (above the attstattarget check vs below it). Looks good to me.

Commits

  1. vacuumdb: Fix --missing-stats-only for partitioned indexes.