Horton

Thread

Commits

  1. Be clearer about when jsonapi's need_escapes is needed

  1. Additional comments around need_escapes in pg_parse_json()

    Corey Huinker <corey.huinker@gmail.com> — 2024-12-20T10:21:45Z

    I recently had occasion to use the pg_parse_json() function for creating
input functions for pg_ndistinct and pg_dependencies.

While it is obvious now that I should have been parsing with
need_escapes=true, it wasn't obvious from the outset, and so I'm proposing
adding a few comments to help the next person come to that conclusion
sooner than I did.

  2. Re: Additional comments around need_escapes in pg_parse_json()

    Andrew Dunstan <andrew@dunslane.net> — 2024-12-21T14:56:57Z

    On 2024-12-20 Fr 5:21 AM, Corey Huinker wrote:
> I recently had occasion to use the pg_parse_json() function for 
> creating input functions for pg_ndistinct and pg_dependencies.
>
> While it is obvious now that I should have been parsing with 
> need_escapes=true, it wasn't obvious from the outset, and so I'm 
> proposing adding a few comments to help the next person come to that 
> conclusion sooner than I did.



Comments are not quite accurate, but I'll look at cleaning them up and 
adding them.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  3. Re: Additional comments around need_escapes in pg_parse_json()

    Corey Huinker <corey.huinker@gmail.com> — 2024-12-23T07:15:01Z

    >
>
> Comments are not quite accurate, but I'll look at cleaning them up and
> adding them.
>

Much appreciated. Also, I don't think we need all of the comments, but I
figured it was easier for me to comment at every possible good place, and
let you pick your favorites.

  4. Re: Additional comments around need_escapes in pg_parse_json()

    Andrew Dunstan <andrew@dunslane.net> — 2025-01-19T14:21:27Z

    On 2024-12-23 Mo 2:15 AM, Corey Huinker wrote:
>
>
>     Comments are not quite accurate, but I'll look at cleaning them up
>     and
>     adding them.
>
>
> Much appreciated. Also, I don't think we need all of the comments, but 
> I figured it was easier for me to comment at every possible good 
> place, and let you pick your favorites.



done.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com