Re: [PATCH] Allow UNLISTEN during recovery
Shay Rojansky <roji@roji.org>
From: Shay Rojansky <roji@roji.org>
To: Mitar <mmitar@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-16T15:11:36Z
Lists: pgsql-hackers
Attachments
- 0003-Allow-UNLISTEN-during-recovery.patch (text/x-patch) patch 0003
> > On Tue, Jan 15, 2019 at 10:17 AM Shay Rojansky <roji@roji.org> wrote: > > Unfortunately I'm extremely tight for time at the moment and don't have > time to do the appropriate hot standby setup to test this... As the patch > is pretty straightforward, and since I'm hoping you guys execute the tests > on your end, I hope that's acceptable. If it's absolutely necessary for me > to test the patch locally, let me know and I'll do so. > > I would definitely prefer if you could run the tests. You might > discover that your patch does not sufficiently address tests. Please > do so and confirm here that it works for you and then I can do another > review. > Thanks for insisting - I ended up setting up the environment and running the tests, and discovering that some test-related changes were missing. Here's a 3rd version of the patch. Hope this is now in good shape, let me know if you think anything else needs to be done.
Commits
-
Allow UNLISTEN in hot-standby mode.
- ebfe20dc706b 12.0 landed
- e8ec19cd13a5 10.7 landed
- c0aed6959541 11.2 landed
- 741ee48900c5 9.5.16 landed
- 549d2a238a70 9.4.21 landed
- 0d5b27351225 9.6.12 landed