Re: BUG #17564: Planner bug in combination of generate_series(), unnest() and ORDER BY
Martijn van Oosterhout <kleptog@gmail.com>
From: Martijn van Oosterhout <kleptog@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-08-03T21:12:11Z
Lists: pgsql-bugs
Hoi Tom, On Wed, 3 Aug 2022 at 16:56, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Richard Guo <guofenglinux@gmail.com> writes: > > On Tue, Aug 2, 2022 at 4:50 PM Martijn van Oosterhout <kleptog@gmail.com > > > > wrote: > >> Now it's morning I've thought of a way to reproduce it more easily, see > >> the attached script. > > > Thanks for the report! I can reproduce it on HEAD. > > FWIW, this reproduces the bug for me in v13 and v14, but not v15 or HEAD. > While the method to fix the bug seems clear enough, it doesn't seem > like we have a test case that's stable enough to be worth anything > as a regression test. Hmmm... > > Looking at what Richard has uncovered, it appears the issue is related to the table simply being big enough that it considers a parallel seqscan plan, and then fails. Something I can look into in the morning. The part I haven't seen explained is why the generate_series() is important. My guess is that if you replace it with an expression it is no longer an SRF and it produces some completely different plan that prevents the problematic path being triggered. Nice that the problem has been found! -- Martijn van Oosterhout <kleptog@gmail.com> http://svana.org/kleptog/
Commits
-
Add proper regression test for the recent SRFs-in-pathkeys problem.
- cc116479917b 16.0 landed
- 8d38ccafca93 13.8 landed
- 1a9ac84923b8 14.5 landed
- 11e7d626cee4 15.0 landed
-
Fix incorrect tests for SRFs in relation_can_be_sorted_early().
- da4ed7588132 13.8 landed
- 445b9020c97f 14.5 landed
- 1aa8dad41ffa 16.0 landed
- 14168d57bb91 15.0 landed
-
Optimize order of GROUP BY keys
- db0d67db2401 15.0 cited