Re: Error on failed COMMIT

Dave Cramer <davecramer@postgres.rocks>

From: Dave Cramer <davecramer@postgres.rocks>

To: David Steele <david@pgmasters.net>

Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Tony Locke <tlocke@tlocke.org.uk>, Shay Rojansky <roji@roji.org>, Bruce Momjian <bruce@momjian.us>, Robert Haas <robertmhaas@gmail.com>, Vik Fearing <vik@postgresfriends.org>, Tom Lane <tgl@sss.pgh.pa.us>, Vladimir Sitnikov <sitnikov.vladimir@gmail.com>, "Haumacher, Bernhard" <haui@haumacher.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-03-25T19:07:17Z

Lists: pgsql-hackers

On Thu, 25 Mar 2021 at 12:04, David Steele <david@pgmasters.net> wrote:

> On 1/26/21 1:02 PM, Dave Cramer wrote:
> > On Tue, 26 Jan 2021 at 12:46, Laurenz Albe <laurenz.albe@cybertec.at
> > <mailto:laurenz.albe@cybertec.at>> wrote:
> >
> >     I see your point from the view of the JDBC driver.
> >
> >     It just feels hacky - somewhat similar to what you say
> >     above: don't go through the normal transaction rollback steps,
> >     but issue an error message.
> >
> >     At least we should fake it well...
> >
> > OK, let me look into how we deal with COMMIT and CHAIN.
> >
> > I can see some real issues with this as Vik pointed out.
>
> Test are failing on the cfbot for this patch and it looks like a new
> patch is needed from Dave, at the least, so marking Waiting on Author.
>
> Should we be considering this patch Returned with Feedback instead?
>
>
Not sure, at this point the impetus for this is not getting a lot of
traction.
Honestly I think the approach I took is too simple and I don't have the
inclination at the moment to
rewrite it.


Dave Cramer
www.postgres.rocks

> Regards,
> --
> -David
> david@pgmasters.net
>