Horton

Re: Binary support for pgoutput plugin

Dave Cramer <davecramer@gmail.com>

View thread View on postgr.es
From: Dave Cramer <davecramer@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>, David Fetter <david@fetter.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-06-05T23:05:05Z
Lists: pgsql-hackers 
Hi,


On Wed, 5 Jun 2019 at 18:50, Andres Freund <andres@anarazel.de> wrote:

> Hi,
>
> On 2019-06-05 18:47:57 -0400, Dave Cramer wrote:
> > So one of the things they would like added is to get not null information
> > in the schema record. This is so they can mark the field Optional in
> Java.
> > I presume this would also have some uses in other languages. As I
> > understand it this would require a protocol bump. If this were to be
> > accepted are there any outstanding asks that would useful to add if we
> were
> > going to bump the protocol?
>
> I'm pretty strongly opposed to this. What's the limiting factor when
> adding such information? I think clients that want something like this
> ought to query the database for catalog information when getting schema
> information.
>

I'm not intimately familiar with their code. I will query them more about
the ask.

I am curious why you are "strongly" opposed however. We already have the
information. Adding doesn't seem onerous.

Dave

Commits

  1. Weaken type-OID-matching checks in array_recv and record_recv.

  2. Fix construction of updated-columns bitmap in logical replication.

  3. Allow logical replication to transfer data in binary format.

  4. Phase 2 pgindent run for v12.