Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use PqMsg_* macros in postgres.c.

  1. Small patch to use pqMsg_Query instead of `Q`

    Dave Cramer <davecramer@gmail.com> — 2025-01-07T15:41:24Z

    Greetings,

Previously we have replaced the use of literal characters with pqMsg*. Not
sure how this one escaped detection.

Patch attached.

Dave Cramer

  2. Re: Small patch to use pqMsg_Query instead of `Q`

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2025-01-07T16:25:31Z

    On Tue, Jan 7, 2025 at 12:42 PM Dave Cramer <davecramer@gmail.com> wrote:

> Greetings,
>
> Previously we have replaced the use of literal characters with pqMsg*. Not
> sure how this one escaped detection.
>
> Patch attached.
>
>
LGTM... looks like a leftover from f4b54e1e.

Regards,

-- 
Fabrízio de Royes Mello

  3. Re: Small patch to use pqMsg_Query instead of `Q`

    Nathan Bossart <nathandbossart@gmail.com> — 2025-01-07T16:58:40Z

    On Tue, Jan 07, 2025 at 01:25:31PM -0300, Fabrízio de Royes Mello wrote:
> On Tue, Jan 7, 2025 at 12:42 PM Dave Cramer <davecramer@gmail.com> wrote:
>> Previously we have replaced the use of literal characters with pqMsg*. Not
>> sure how this one escaped detection.

It's not the first to escape detection, and it probably won't be the
last...

> LGTM... looks like a leftover from f4b54e1e.

I'll commit this shortly.  I'd argue this falls into the category of
"low-risk fixes," so I'll also plan on back-patching it to v17 (where
protocol.h was first added).

-- 
nathan

  4. Re: Small patch to use pqMsg_Query instead of `Q`

    Nathan Bossart <nathandbossart@gmail.com> — 2025-01-07T21:36:37Z

    Committed.

-- 
nathan