Re: Binary support for pgoutput plugin

Dave Cramer <davecramer@gmail.com>

From: Dave Cramer <davecramer@gmail.com>

To: Petr Jelinek <petr.jelinek@2ndquadrant.com>

Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2019-06-11T19:44:02Z

Lists: pgsql-hackers

Attachments

0001-First-pass-at-working-code-without-subscription-opti.patch (application/octet-stream) patch 0001

OK, before I go too much further down this rabbit hole I'd like feedback on
the current code. See attached patch

There is one obvious hack where in binary mode I reset the input cursor to
allow the binary input to be re-read
>From what I can tell the alternative is to convert the data in
logicalrep_read_tuple but that would require moving a lot of the logic
currently in worker.c to proto.c. This seems minimally invasive.

and thanks Petr for the tip to use pglogical for ideas.

Thanks,
Dave Cramer



>
>

Commits

Weaken type-OID-matching checks in array_recv and record_recv.
- 670c0a1d474b 14.0 landed
Fix construction of updated-columns bitmap in logical replication.
- e8de627a3e05 11.9 landed
- d5daae47db5e 14.0 landed
- 71e561bd4bc2 12.4 landed
- 39d6aec1927c 10.14 landed
- 2f1f189cf880 13.0 landed
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 landed
Phase 2 pgindent run for v12.
- 8255c7a5eeba 12.0 cited