Horton

Re: Binary support for pgoutput plugin

Dave Cramer <davecramer@gmail.com>

View thread View on postgr.es
From: Dave Cramer <davecramer@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-11-05T12:16:10Z
Lists: pgsql-hackers

Attachments

On Sun, 3 Nov 2019 at 21:47, Thomas Munro <thomas.munro@gmail.com> wrote:

> On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecramer@gmail.com> wrote:
> > Ok, I've rebased and reverted logicalrep_read_insert
>
> Hi Dave,
>
> From the code style police (actually just from cfbot, which is set up
> to complain about declarations after statements, a bit of C99 we
> aren't ready for):
>
> proto.c:557:6: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
>       int len = pq_getmsgint(in, 4); /* read length */
>       ^
> proto.c:573:6: error: ISO C90 forbids mixed declarations and code
> [-Werror=declaration-after-statement]
>       int len = pq_getmsgint(in, 4); /* read length */
>       ^
>

Thomas,

Thanks for the review.

See attached

Commits

  1. Weaken type-OID-matching checks in array_recv and record_recv.

  2. Fix construction of updated-columns bitmap in logical replication.

  3. Allow logical replication to transfer data in binary format.

  4. Phase 2 pgindent run for v12.