Re: Binary support for pgoutput plugin

Dave Cramer <davecramer@gmail.com>

From: Dave Cramer <davecramer@gmail.com>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: Petr Jelinek <petr@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-07-02T16:41:14Z

Lists: pgsql-hackers

Attachments

0001-First-pass-at-working-code-without-subscription-opti.patch (application/octet-stream) patch 0001
0005-Remove-C99-declaration-and-code.patch (application/octet-stream) patch 0005
0002-add-binary-column-to-pg_subscription.patch (application/octet-stream) patch 0002
0004-get-relid-inside-of-logical_read_insert.patch (application/octet-stream) patch 0004
0003-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch (application/octet-stream) patch 0003
0006-make-sure-the-subcription-is-marked-as-binary.patch (application/octet-stream) patch 0006
0007-check-that-the-subscriber-is-compatible-with-the-pub.patch (application/octet-stream) patch 0007
0008-Changed-binary-and-changed-to-format-and-use-existin.patch (application/octet-stream) patch 0008

rebased

Thanks,

Dave Cramer


On Wed, 1 Jul 2020 at 06:43, Dave Cramer <davecramer@gmail.com> wrote:

> Honestly I'm getting a little weary of fixing this up only to have the
> patch not get reviewed.
>
> Apparently it has no value so unless someone is willing to review it and
> get it committed I'm just going to let it go.
>
> Thanks,
>
> Dave Cramer
>
>
> On Wed, 1 Jul 2020 at 04:53, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> > On 7 Apr 2020, at 21:45, Dave Cramer <davecramer@gmail.com> wrote:
>>
>> > New patch that fixes a number of errors in the check for validity as
>> well as reduces the memory usage by
>> > dynamically allocating the data changed as well as collapsing the
>> changed and binary arrays into a format array.
>>
>> The 0001 patch fails to apply, and possibly other in the series.  Please
>> submit
>> a rebased version. Marking the CF entry as Waiting for Author in the
>> meantime.
>>
>> cheers ./daniel
>
>

Commits

Weaken type-OID-matching checks in array_recv and record_recv.
- 670c0a1d474b 14.0 landed
Fix construction of updated-columns bitmap in logical replication.
- e8de627a3e05 11.9 landed
- d5daae47db5e 14.0 landed
- 71e561bd4bc2 12.4 landed
- 39d6aec1927c 10.14 landed
- 2f1f189cf880 13.0 landed
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 landed
Phase 2 pgindent run for v12.
- 8255c7a5eeba 12.0 cited