Horton

Re: Correct documentation for protocol version

Dave Cramer <davecramer@gmail.com>

View thread
From: Dave Cramer <davecramer@gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-22T14:34:55Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Do not hardcode PG_PROTOCOL_LATEST in NegotiateProtocolVersion

Attachments

On Fri, 11 Apr 2025 at 11:02, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:

> On Fri, 11 Apr 2025 at 22:57, Dave Cramer <davecramer@gmail.com> wrote:
> > Well this isn't quite true since if you request 3.0 and have invalid
> options it will return 3.0, which is not the highest supported minor
> version.
>
> Probably good to update this section too then to be similarly correct
> as your already updated section. Maybe also good to clarify further
> that the version that the server responds with is the protocol version
> that will be used during the following communication.
>

I've updated the wording to specify that the negotiateProtocol message will
only be sent if the client requests a major version the server supports.
Also added a note saying that this will be the protocol version that will
be used for the duration of the connectin

See attached.