Re: [PATCH] Print error when libpq-refs-stamp fails

Rachel Heaton <rachelmheaton@gmail.com>

From: Rachel Heaton <rachelmheaton@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2021-09-28T15:52:59Z
Lists: pgsql-hackers

Attachments

On Tue, Sep 28, 2021 at 6:14 AM Daniel Gustafsson <daniel@yesql.se> wrote:

>
> Since it's not actually libpq which calls exit (no such patch would ever be
> committed), I think it would be clearer to indicate that a library linked to is
> the culprit.  How about something like "libpq must not be linked against any
> library calling exit"?
>

Excellent update to the error message. Patch attached.

Commits

  1. Fix check for trapping exit() calls in libpq

  2. Provide error hint on exit() check when building libpq