Horton

Re: psql \dh: List High-Level (Root) Tables and Indexes

Sadeq Dousti <msdousti@gmail.com>

View thread
From: Sadeq Dousti <msdousti@gmail.com>
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-02-26T00:27:23Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. psql \dP: list partitioned tables and indexes

Attachments

Dear Greg,

Thank you so much for the kind and prompt review!

Please find the patches attached. The second patch (0002) is where I
applied the requested changes.

Best regards,
Sadeq Dousti


On Wed, Feb 26, 2025 at 1:01 AM Greg Sabino Mullane <htamfids@gmail.com>
wrote:

> The patch applies cleanly, and works as advertised. Nice work!
>
> Quick notes:
>
> * doc/src/sgml/ref/psql-ref.sgml
>
> In the varlistentry section, the order should be the same as the other
> places (N after m)
>
> Line 1644 has an extra comma
>
> Line 1651, maybe the example is simpler as \dNt to keep the wording
> better, because "indexes that are not partitions" looks odd.
>
> These bits:
>
>   pg_log_error("Did not find any%s relations named \"%s\".",
>     no_partition_description, pattern);
>
> are not good for translation. We want things simple with replaceable
> args/constants, but not replaceable words.
>
> I think the myopt.title ones are fine.
>
> * bin/psql/help.c:
>
> \\dN[Sx+] [PATTERN]     list relation, table, index (no partitions)
>
> better as:
>
> \\dN[Sx+] [PATTERN]     list tables and indexes (no partitions)
>
> Cheers,
> Greg
>
> --
> Crunchy Data - https://www.crunchydata.com
> Enterprise Postgres Software Products & Tech Support
>
>