Horton
Menu

Re: [WIP] pg_ping utility

Phil Sorber <phil@omniti.com>

View thread
From: Phil Sorber <phil@omniti.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL-development Hackers <pgsql-hackers@postgresql.org>
Date: 2012-11-16T04:38:09Z
Lists: pgsql-hackers 
On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Hum, it is not really consistent to use a magic number here, particularly in
> the case where an additional state would be added in the enum PGPing. So why
> not simply return PQPING_NO_ATTEMPT when there are incorrect options or you
> show the help and exit? Looks like the best option here.

Good point. I will make that change as well.

> --
> Michael Paquier
> http://michael.otacoo.com