Re: [WIP] pg_ping utility

On Sun, Dec 23, 2012 at 9:29 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>
>
> On Sat, Dec 22, 2012 at 4:07 AM, Phil Sorber <phil@omniti.com> wrote:
>>
>>
>> Added new version with default verbose and quiet option. Also updated
>> docs to reflect changes.
>
> Thanks for the updated patches.
>
> Here is the status about the binary patch:
> - Code compiles without any warnings
> - After testing the patch, it behaves as expected, default option is now
> verbose, the output can be hidden using -q or --quiet
> However, I still have the following comments:
> - in pg_isready.c, the function "help" needs to be static.

I have no objection to making this static, but curious what is your
reason for it here?

> - the list of options called with getopt_long should be classified in
> alphabetical order (the option q is not at the correct position)
> d:h:p:U:qV => d:h:p:qU:V
>
> Then, about the doc patch:
> - docs compile correctly (I did a manual check)
> - I am not a native English speaker, but the docs look correct to me. There
> are enough examples and description is enough. No problems either with the
> sgml format.
>
> Once the 2 small things I noticed are fixed, this patch can be marked as
> ready for committer.

Ok, I will get an updated version later today.

> Thanks,
> --
> Michael Paquier
> http://michael.otacoo.com