Horton

Thread

Commits

  1. Mention jsonlog in description of logging_collector in GUC table

  1. jsonlog missing from logging_collector description

    Umar Hayat <postgresql.wizard@gmail.com> — 2025-01-31T09:09:48Z

    Hi Hackers,
Enabling logging_collector is required for json log. During jsonlog
implementation [1], log destination and logging_collector comments in
postgresql.conf.sample and documentation was updated but
logging_collector short description was not updated in guc.c (which is
guc_table.c now).
Attached is the patch for this minor fix.

[1] https://www.postgresql.org/message-id/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=X7dDLyqUExHg@mail.gmail.com

Regards
-- 
Umar Hayat
Bitnine (https://bitnine.net/)

  2. Re: jsonlog missing from logging_collector description

    Michael Paquier <michael@paquier.xyz> — 2025-01-31T09:12:38Z

    On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> Enabling logging_collector is required for json log. During jsonlog
> implementation [1], log destination and logging_collector comments in
> postgresql.conf.sample and documentation was updated but
> logging_collector short description was not updated in guc.c (which is
> guc_table.c now).
> Attached is the patch for this minor fix.
> 
> [1] https://www.postgresql.org/message-id/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=X7dDLyqUExHg@mail.gmail.com

Thanks for the report.  This one is on me, will fix.
--
Michael

  3. Re: jsonlog missing from logging_collector description

    Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2025-01-31T11:41:31Z

    On Fri, Jan 31, 2025 at 2:43 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> > Enabling logging_collector is required for json log. During jsonlog
> > implementation [1], log destination and logging_collector comments in
> > postgresql.conf.sample and documentation was updated but
> > logging_collector short description was not updated in guc.c (which is
> > guc_table.c now).
> > Attached is the patch for this minor fix.
> >
> > [1] https://www.postgresql.org/message-id/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=X7dDLyqUExHg@mail.gmail.com
>
> Thanks for the report.  This one is on me, will fix.
> --
> Michael

- gettext_noop("Start a subprocess to capture stderr output and/or
csvlogs into log files."),
+ gettext_noop("Start a subprocess to capture stderr, csvlog and/or
jsonlog into log files."),

Did you remove the word "output" intentionally? It is related to
stderr and not jsonlog. I think, stderr usually refers to a file or a
file descriptor hence we added word "output" there. I wouldn't touch
it.

-- 
Best Wishes,
Ashutosh Bapat

  4. Re: jsonlog missing from logging_collector description

    Umar Hayat <postgresql.wizard@gmail.com> — 2025-01-31T12:48:25Z

    On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Fri, Jan 31, 2025 at 2:43 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> > > Enabling logging_collector is required for json log. During jsonlog
> > > implementation [1], log destination and logging_collector comments in
> > > postgresql.conf.sample and documentation was updated but
> > > logging_collector short description was not updated in guc.c (which is
> > > guc_table.c now).
> > > Attached is the patch for this minor fix.
> > >
> > > [1] https://www.postgresql.org/message-id/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=X7dDLyqUExHg@mail.gmail.com
> >
> > Thanks for the report.  This one is on me, will fix.
> > --
> > Michael
>
> - gettext_noop("Start a subprocess to capture stderr output and/or
> csvlogs into log files."),
> + gettext_noop("Start a subprocess to capture stderr, csvlog and/or
> jsonlog into log files."),
>
> Did you remove the word "output" intentionally? It is related to
> stderr and not jsonlog. I think, stderr usually refers to a file or a
> file descriptor hence we added word "output" there. I wouldn't touch
> it.

Yes, It was omitted intentionally to match the wording in
postgresql.conf.sample and documentation of logging_collector.

>
> --
> Best Wishes,
> Ashutosh Bapat



-- 
Umar Hayat
Bitnine (https://bitnine.net/)

  5. Re: jsonlog missing from logging_collector description

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-01-31T15:19:29Z

    Umar Hayat <postgresql.wizard@gmail.com> writes:
> On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
>> - gettext_noop("Start a subprocess to capture stderr output and/or
>> csvlogs into log files."),
>> + gettext_noop("Start a subprocess to capture stderr, csvlog and/or
>> jsonlog into log files."),
>> 
>> Did you remove the word "output" intentionally? It is related to
>> stderr and not jsonlog. I think, stderr usually refers to a file or a
>> file descriptor hence we added word "output" there. I wouldn't touch
>> it.

> Yes, It was omitted intentionally to match the wording in
> postgresql.conf.sample and documentation of logging_collector.

FWIW, it seems weird to me to use the word "output" with only one
of those terms.  The proposed new wording is fine by me, or we
could do

"Start a subprocess to capture stderr, csvlog and/or jsonlog output
into log files."

I read that as 'stderr, csvlog and/or jsonlog' all being modifiers
for 'output', which is sensible grammar.

			regards, tom lane

  6. Re: jsonlog missing from logging_collector description

    Michael Paquier <michael@paquier.xyz> — 2025-02-01T02:20:55Z

    On Fri, Jan 31, 2025 at 10:19:29AM -0500, Tom Lane wrote:
> FWIW, it seems weird to me to use the word "output" with only one
> of those terms.  The proposed new wording is fine by me, or we
> could do
> 
> "Start a subprocess to capture stderr, csvlog and/or jsonlog output
> into log files."
> 
> I read that as 'stderr, csvlog and/or jsonlog' all being modifiers
> for 'output', which is sensible grammar.

FWIW, I'd choose for keeping things simpler and just remove the word
"output", keeping this list as all the possible values.  Hence, the
patch is OK here:
-    gettext_noop("Start a subprocess to capture stderr output and/or csvlogs into log files."),
+    gettext_noop("Start a subprocess to capture stderr, csvlog and/or jsonlog into log files."),
--
Michael

  7. Re: jsonlog missing from logging_collector description

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-02-01T02:32:42Z

    Michael Paquier <michael@paquier.xyz> writes:
> FWIW, I'd choose for keeping things simpler and just remove the word
> "output", keeping this list as all the possible values.  Hence, the
> patch is OK here:
> -    gettext_noop("Start a subprocess to capture stderr output and/or csvlogs into log files."),
> +    gettext_noop("Start a subprocess to capture stderr, csvlog and/or jsonlog into log files."),

Sure, fine by me.

			regards, tom lane

  8. Re: jsonlog missing from logging_collector description

    Michael Paquier <michael@paquier.xyz> — 2025-02-03T03:04:44Z

    On Fri, Jan 31, 2025 at 09:32:42PM -0500, Tom Lane wrote:
> Sure, fine by me.

This one has been done as d61b9662b09e.
--
Michael