Re: Regression tests fail with musl libc because libpq.so can't be loaded

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Christophe Pettus <xof@thebuild.com>, Wolfgang Walther <walther@technowledgy.de>, Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>

Date: 2024-03-20T07:16:14Z

Lists: pgsql-bugs, pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow "make check"-style testing to work with musl C library.
- d82605bcd666 14.12 landed
- 8a92b70c11ba 17.0 landed
- 7651fd387697 16.3 landed
- 7124e7d528a8 12.19 landed
- 3c3f4fd741d0 15.7 landed
- 243e9953281f 13.15 landed
Fix compiler warnings on MSYS2
- 8c6d30f21139 13.0 cited

On Wed, Mar 20, 2024 at 2:03 AM Peter Eisentraut <peter@eisentraut.org>
wrote:

> On 17.03.24 11:33, Christophe Pettus wrote:
> >> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther@technowledgy.de>
> wrote:
> >>
> >> Nailed it. PS_USE_NONE fixes it.
> >
> > Given the musl (still?) does not define a preprocessor macro specific to
> it, is there a way of improving the test in pg_status.c to catch this
> case?  It seems wrong that the current test passes a case that doesn't
> actually work.
> >
>
> We could turn it around and do
>
> #if defined(__linux__)
> #if defined(__GLIBC__) || defined(__UCLIBC__ )
> #define PS_USE_CLOBBER_ARGV
> #else
> #define PS_USE_NONE
> #endif
> #endif
>
>
>
>
I like it. Neat and minimal.

cheers

andrew