Re: Clear base backup progress reporting on error

On Wed, Jul 1, 2026 at 10:17 AM Fujii Masao <masao.fujii@gmail.com> wrote:

> On Fri, Jun 26, 2026 at 8:08 PM Chao Li <li.evan.chao@gmail.com> wrote:
> >
> >
> >
> > > On Jun 26, 2026, at 18:46, Fujii Masao <masao.fujii@gmail.com> wrote:
> > >
> > > On Fri, Jun 26, 2026 at 5:59 PM Chao Li <li.evan.chao@gmail.com>
> wrote:
> > >> This patch makes the following changes:
> > >
> > > Thanks for the report and patch!
> > >
> > >> I don’t think this is a serious bug, because with the usual
> pg_basebackup command path, the client normally disconnects after the
> error, so the stale progress entry is not observable. It is mainly visible
> when the same replication connection stays open after the failed
> BASE_BACKUP command. So I feel it might not be worth adding a TAP test.
> > >
> > > +1
> > >
> > > You may think this isn't worth backpatching to the stable branches
> > > for the same reason?
> > >
> >
> > I personally don’t feel back-patch is needed.
>
> I've pushed the patch. Thanks!
>
> I backpatched it to v15 but skipped v14 because v14 lacks the bbsink
> infrastructure, so the fix does not apply cleanly there. Also, the bug
> does not affect the backup itself and is normally not observable
> when using pg_basebackup.
>
>
>
This has upset the ABI compliance checker (see <
https://buildfarm.postgresql.org/cgi-bin/show_failures.pl?max_days=3&stage=abi-compliance-check&filter=Submit>
. Looks like you need to update the  .abi-compliance-history file on the
affected back branches.

cheers

andrew