Horton
Menu

Re: Pgoutput not capturing the generated columns

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, pgsql-hackers@lists.postgresql.org, euler@eulerto.com
Date: 2024-09-27T00:03:14Z
Lists: pgsql-hackers 
On Wed, Sep 25, 2024 at 11:15 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi, I have written a new patch to document this feature.
>
> The patch adds a new section to the "Logical Replication" chapter. It
> applies atop the existing patches.
>
> v33-0001 (same as v32-0001)
> v33-0002 (same as v32-0002)
> v33-0003 (new DOCS)
>
> Review comments are welcome.

Thank you for updating the patch!

I think that the patch doesn't have regression tests to check if
generated column data is replicated to the subscriber as expected. I
think we should include some tests for this feature (especially with
other features such as column list).

Also, when testing this feature, I got the following warning message
even if the publication has publish_generated_columns = true:

=# create publication pub for table test (a, c) with
(publish_generated_columns = true);
WARNING:  specified generated column "c" in publication column list
for publication with publish_generated_columns as false

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.