Horton

Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com
Date: 2025-10-07T17:25:29Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.

On Tue, Oct 7, 2025 at 3:59 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
> On Mon, Oct 6, 2025 at 12:37 PM Michael Paquier <michael@paquier.xyz> wrote:
> > On Mon, Oct 06, 2025 at 02:15:25AM +0900, Etsuro Fujita wrote:
> > > The isolation test fails.  I think you failed to update the expected
> > > file.  Also, you left the useless alias for table a alone...
> >
> > Yep, the EXPLAIN plan was missing.  Another thing that you have missed
> > is to update postgres_fdw's .gitignore so as it discards /output_iso/.
> >
> > The updated patch attached, labelled v6, addresses all that.
>
> LGTM.  Thanks for updating the patch including the .gitignore file!

+1

> Sawada-san, the patch uses the fix for ExecScanFetch that I proposed,
> so if you wouldn't mind, I'd like to take care of this.

Thank you. That would be great. Please feel free to edit the commit
message, subjects, and credits. I should have credited Fujita-san as
an author or co-author with me since most changes are based on
suggestions by Fujita-san.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com